A suggestion on NodeMixin interface #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think it would be more convenient if two NodeMixin class methods, property and index take arbitrary number of symbols followed by an optional hash.
Then we could write as follows,
This should feel natural to most Ruby developers.
I made changes to the both methods and spec files were extended accordingly.
The change is backward compatible.
So, what do you think? Please pull this patch if you think it's appropriate.
Thanks!